[Spastic Hamburger]

And devakm just uploaded the code!

[Spastic Hamburger]

It looks like most of the ClassWizard notations in the files can be removed as it was just a marker for the GUI tool instead of something being done in the tool-chain? Not entirely sure but if so, that’ll help clean up the headers to be more readable.

Additionally, the custom string implementation in common/string/sstring.h isn’t used much and CString is used more predominantly so we may be able to mark it for removal. Ultimately, the plan is to replace the nonstandard string types with std::string but that will take some time to retool the code to use the functions in the C++ standard

Still need to update the tasks list from this thread more but I’d rather code than go through the thread and do that mindless work…. 😛

Adding the missing includes to the GUI files is coming along nicely and the code is becoming much more readable, as well 🙂

Also asked devakm about the TES4Gecko code 🙂

[Spastic Hamburger]

I’ll start by asking devakm about the original code. All that’s available publicly is the packaged JAR file.

AndalayBay still has some of the project files as they are currently working on a straight C# rewrite. No idea if they abandoned the previous attempts or not, though. As I recall, the Morrowind version wasn’t that far along but may still have something useful in it if we’re able to get permission. I’ll need to give that aspect some thought due to stuff in the past. In the meantime, I’ll talk to devakm 🙂

We may not need to actually run the code but time will tell. Don’t remember much about the tool-chain since I last worked with Java in 2010 (I switched to C++ as soon as I learned it) but I do remember that javac compiles the files and you run them with java. Should be the same in OpenJDK.

[Spastic Hamburger]

Spent the last few days watching old Addams Family reruns while recovering from the sinus issue. Was quite fun. It’s a shame the show didn’t go on longer as it had a lot of potential.

Also taking a break from Reincarnated as a Slime to watch How Not to Summon a Demon Lord. It’s another in the goofy anime genre that I really enjoy (Slime just wasn’t cutting it).

Probably should go back to watching old films and/or B-movies at some point but we’ll get there! Got a lot of good quality classics that I want to watch again, such as the Basil Rathbone Holmes films. Those were always enjoyable.

[Spastic Hamburger]

Okay, so we have permission to use TES4Gecko as inspiration for the algorithms with the only stipulation that we provide credit to Gecko for what we borrow. 🙂

[Spastic Hamburger]

Okay, started updating the includes for the UI stuff, which is where most of the missing stuff is. Some of them are a bit obscure but I’ve been adding each one individually. We’ve got things like this:

#include <afx.h>
#include <afxdd_.h>
#include <afxwin.h>
#include <atlstr.h>

Not exactly pretty and commenting them to explain what they’re for may be necessary as the names are a bit obscure.

Additionally, I’ve reached out to devakm regarding TES4Gecko. Since MWEdit will ultimately have a lot of feature overlap, I’ve asked them about the possibility of sharing information to reduce the need to come up with the same algorithms.

[Spastic Hamburger]

Doom now runs on an earbud: https://doombuds.com/

[Spastic Hamburger]

Ugh. BIOS issues like that are no fun. Definitely an odd one 🙁

[Spastic Hamburger]

Need to see The Thomas Crown Affair. Been on the list for years, just haven’t gotten there yet. Still reading a lot! 😛

But the Muppets are wonderful!

Been watching That Time I Got Reincarnated as a Slime. It’s not bad but I can’t seem to really get into it so I may move on soon

Wasn’t able to finish Date A Live: the mid-series OVAs weren’t dubbed and they cover critical aspects of the plot for the final season. 🙁

[Spastic Hamburger]

Yeah, it’s so big GitHub won’t load it. The MWEdit code is pretty crusty. 😛

In reality, most of those are memory alignment warnings in the Windows API. I think GCC ignores warnings in system includes by default (not sure, it’s been a while since I used it) and there may be a switch for VS to turn on.

The MFC stuff will be removed down the road when we make it system agnostic so explicitly defining them where they’re needed will also help with the porting 🙂

Sounds good. We can worry about the PCH stuff later on and focus on getting things working for now. GCC uses a different method than VS for PCH: you can simply have it compile the header files and then it’ll give them preference over the text-based headers without changing anything in the code.

[Spastic Hamburger]

Now that I’ve thought about it, I’m tired of making tiny commits for each file and then waiting several minutes for them to build. It also adds stress to my storage device, which isn’t good. So I’m going to go back to fixing up the includes now that we know that they are the problem. In the process, I’ll probably look at removing stdafx as well. Any objections?

[Spastic Hamburger]

Fixed the WinSock2 errors. Had to add WIN32_LEAN_AND_MEAN to the definitions in the build script. It didn’t work in the code but that may been due to include order (which is still being worked on). The build script will need some cleaning up at some point, more than likely. It’s already on the tracker 🙂

Still working through getting the debug build working.

Edit:

We’re getting closer. There’s at least one error buried somewhere in the 25,000-line build log. Could do a search for it but, even then, it’ll be hard to spot among all of the warning noise.

Looks like it’s complaining about mwedit/script_options.h now when it was fine before. I added the necessary Windows includes but still no luck. It’s complaining about syntax errors but I’m not seeing them. It could be something with the macros. Any ideas? I may merge it into master and see what happens on a release build as it didn’t happen before debug builds were turned on and I started messing with the file paths. I’ll start by doing a direct comparison though that may fail due to the file name changes.

Edit 2:

I was afraid of that. The diff fails between master and dev due to the changes to the file names. May do a test commit with release instead of debug on the dev branch or I may create a new branch so I don’t mess up master… :/

Test branch using Release config comes up with different errors: https://github.com/deathssoul/MWEdit/actions/runs/21091754553/job/60663963134

Weird. Going to start trying to sort through them. Not sure what’s going on here but it looks like we’re dealing with some Windows breakage. Could also be due to WIN32_LEAN_AND_MEAN. Whelp. Will add all of the missing includes it’s complaining about on Release and will go from there and hopefully Debug will get fixed in the meantime.

Maybe this is a good opportunity to go back to adding all of the missing includes?

Working on adding them. Previously, the project was set up in VS to implicitly add the stdafx.h file to each instead of explicitly so several files were missing it. Changing the project structure somehow triggered it crapping out without the explicit includes for some reason. Maybe due to how VS works, not sure. Normally, the compiler would crap out regardless. In any case, I’m going through and adding the missing Windows includes that are necessary for building on Release. Hopefully that’ll also fix Debug but we’ll revisit that once I get these issues fixed. We’ll be moving away from a stdafx.h file in favor of more explicit definitions so that we have a better handle on what’s going on and for better portability.

[Spastic Hamburger]

Read Homer! Not just the Odyssey and the Iliad but the Homeric hymns are also worth a read. 🙂

Ugh! Here, on the other hand, we’re getting a lot of rain right now as part of a cold front. Really hard to stay warm when it’s freezing cold and wet! 😛

[Spastic Hamburger]

Yet another thing to add to the investigation list! Yeah, we may want to swap out that macro with something more modern. There have been a lot of updates to pointer support in recent years 🙂

The debug settings are complaining about missing libraries such as winsock when release does not so I’m going ahead and removing the PCH support to help us sort through everything. Needs to be done anyways and it’ll help us diagnose what’s needed where. This is going to take some more time, it looks like, to untangle the Windows library stuff. This means I’m going to have to remove the mwedit/std_afx.h include from all of the files, which will take another week or so. *sigh* It’s probably as good a time as any.

Er never mind. I just realized that’ll break MFC support. Reverting now….

Will need to keep at it for a while. The MFC headers need to be added to the GUI files before we can remove PCH support. I hope I’m not breaking too much here…. I should probably check the commit log before I do anything more to make sure release would still function

Okay, now we’re back to it complaining about winsock even though we’re not using network code. Weird. Will set it aside for now and take a look another day. Don’t know why turning on debug builds meant trying to use winsock. Here’s the current build log if you want to take a looksie: https://github.com/Walrus-Tech/MWEdit/actions/runs/21025793442/job/60449870823

Did some looking at it appears that winsock is brought in regardless and not all of the MFC includes have been updated to use winsock2. Weird. May or may not be easy to fix.

[Spastic Hamburger]

Test_TemplateArray() in common/container/tem_array is bad. It’s got lines like this: CreatePointer(pTestInt, (long)(12345678l));. That’s incorrect as CreatePointer takes a pointer object and a type, not a number:

#define CreatePointer(pObject, Type) { \
		(pObject) = new Type; \
		if ((pObject) == NULL) { \
			SystemLog.Printf(stderr, _T("Failed to allocate %u bytes!"), sizeof(Type)); \
			throw (_T("Out of Memory!")); \
		} }

I’ll comment those lines out for now as I’m not entirely sure what they’re supposed to accomplish (working through the errors for the DEBUG portions of the code which we haven’t done yet).

Edit:

Going to take another day or so. As usual, I mistyped some of the paths so I’m fixing them as the CI complains. I’m also fixing some MSVC and C++20 compatibilities that exist with the types and preprocessor stuff that wasn’t caught earlier due to the debug builds not being enabled

[Spastic Hamburger]

So setting up different tasks for different branches using GitHub Actions is rather ugly. There’s no clean way to do it in one workflow file as you can only specify the branches on which the file runs, not the tasks. There are two options: set up the jobs section as an if-statement using Git references or have multiple workflow files. I’m leaning towards the latter option as it’s cleaner even if it is another thing to add to the repository. Yuck.

Give me a bit and I’ll copy the file, change the branch, and add the debug flag to the build command. Wish the if-statement version wasn’t so ugly. I hate duplication *sigh*

[Spastic Hamburger]

Yeah, the dogs here love the hammock beds. The lab I used to have used to eat them, though! 😛

These days, my dog mostly ignores the beds and either uses the couch or the beanbag chairs. When she uses the couch, she has a habit of hogging all of the blankets. The other day, she claimed all four of them and piled them all up into a cushion! 😛

Really need to read more Ovid. Most of those old works are on Archive.org. Gutenberg doesn’t have them for whatever reason (at least, they didn’t) but they do have Plato’s Republic! It was a bit of a dry read, if you ask me 😛

Actually, it looks like Gutenberg has added a lot since I last looked for them: https://gutenberg.org/ebooks/subject/27

That category is pretty slim as it looks like things aren’t fully categorized but more come up in this query: https://gutenberg.org/ebooks/search/?query=Legends

[Spastic Hamburger]

Looks like openSUSE has it in the repo: https://software.opensuse.org/package/OpenRGB

Should be able to install it easily from the command-line (my preferred method) using zypper. 🙂

Not in PopOS (at least, the version I’m on as the upgrade hasn’t landed yet) but Ubuntu has it: https://packages.ubuntu.com/questing/openrgb

Arch has it as well: https://archlinux.org/packages/extra/x86_64/openrgb/

[Spastic Hamburger]

Just finished correcting all of the paths. All of those commits have been uploaded. I haven’t yet merged things into master, though. I may also look at setting up the CI to create debug builds on the dev branch first, as well. Anyways, there may be stuff to fix once the CI runs on it (quite possibly the resource files as they choked before when I was messing with the paths). Will do all of that another day. My neck needs a break 🙂

[Spastic Hamburger]

Good news! Both GNOME and KDE have a collection of solitaire games! You won’t get the community features but you can play them to your heart’s content!

Weird. Could be something with the interaction of OpenRGB. I never got into RGB lighting much except for the color backlight that I left at default settings. Never had a problem in any application that I can recall.

OpenRGB is apparently available for Linux but requires Qt, which KDE uses. Not an option for me, of course, as we generally know how I feel about Qt 🙂

I’m not sure if it’s in the official package repos though but I can check. Most distros have a web-based tool to search packages in their repos. I’ll also look around for a GTK-based lighting tool

[Author]

Posts