[Spastic Hamburger]

Thanks. 🙂

Ultimately, they’ll be swapped out when we switch GUI toolkits but we can revisit things then 🙂

Looked at it more closely and ON_WM_TIMER() is supposed to map to an UINT_PTR while the code is trying to use just UINT. Probably a change in MFC signatures at some point over the last couple of decades. That fixed that error when I changed the type. Got some more, which isn’t unexpected. It was able to work through 92 files this time so we’re definitely getting closer. There will be more const types to correct but I’ll let it point me to them so I don’t have to go on a treasure hunt 🙂

Yeah, I’m not entirely sure what all of the stuff in Common is for. It could be for other projects totally unrelated to the community as I haven’t seen it used anywhere else. With the time stuff, he’s using it to profile stuff in debug mode and in general in the script compiler but those all use dl_time instead. Lately, he’s pretty focused on admin duties at UESP but does update the Edit code from time to time for compatibility. He even added some stuff to it for Starfield in a separate repository. 🙂

Edit:

We’re getting some pointer truncation warnings in project/mwrecordmap.h that are annoying to see in the log so I’ll look at fixing them up at some point. Just tired of seeing them 😛

Still working through compatibility errors. It’s also caught some missing includes, which is nice. Once it’s building, I’ll clean things up a tad before squashing the commits and merging 🙂

[Spastic Hamburger]

So it sounds like there’s a switch being used for MSVC to relax the casting rules for C++. Sorry, things are still coming back to me but I’m getting there. 🙂

Would be better to fix it manually, anyways, so I guess I’ll fix up the required casts for now. Was hoping to do them later but, hey, it’s all part of improving the code quality. It’ll also help with getting it ready for cross-platform support as compilers on Linux are extremely strict. 🙂

What does the message map do, anyway? The documentation I found on MSDN on the block didn’t link to an explanation of what a message block is in the context of MFC

Eventually, I hope to replace much of the time functions with those from ctime but there may still be some OS specific stuff needed. Right now, that class isn’t used in the program so it’s a likely candidate for removal at some point after we get the basic changes done for building.

We can definitely add it to the issue tracker, though. 🙂

Who knows? We may find a use for some of the miscellaneous capabilities of the common support library down the road

I’ll flip on all of the warnings after we get the build working to help us with compiling our list of stuff to fix. May be worth rerunning cppcheck and cpplint, too. Afterwards, we may want to get the stuff added to the issue tracker by warning type to help keep everything in one place. Up until now, most of the work has been related to updating the style, syntax, and infrastructure but once the build script is working, that’ll unlock capabilities that we didn’t have before. We’re definitely getting there! 🙂

I’ll update the threads tomorrow with an update on where things stand with the build script 🙂

[Spastic Hamburger]

I’ve temporarily turned off all of the extra warnings until we get things working.

New issue! This has to deal with the message maps that the MFC API uses. It’s complaining about bad casting even though it works in the VS project files, just not the Meson script so I suspect there’s a setting in there that may need to be transferred over as well. Any ideas on that? Here’s the error I’m looking at
Yep, the CI script is fully set up to work with Ninja and VS 🙂
meson setup --buildtype release --vsenv build
That’s where we tell it which back-end to use. I can also tell it to use MSBuild instead of Ninja but it looks like Ninja is working and the issues have to do with missing some special overrides that were done twenty years back.

[Spastic Hamburger]

Okay, got that minor issue fixed. Had to add this to the Meson script:

add_project_arguments('-D_AFXDLL',
                      language: 'cpp')

Now that it’s using C++20 as the standard, it’s exposed a few other real code errors that I’m working on fixing. 🙂

Got one that’s an issue with the Windows API that I’m unfamiliar with:

../Common/Time/tasktime.cpp(231): error C2664: 'MMRESULT timeSetEvent(UINT,UINT,LPTIMECALLBACK,DWORD_PTR,UINT)': cannot convert argument 3 from 'void (__cdecl *)(UINT,UINT,DWORD,DWORD,DWORD)' to 'LPTIMECALLBACK'
../Common/Time/tasktime.cpp(231): note: None of the functions with this name in scope match the target type

Here’s the line it’s crapping out on: https://github.com/deathssoul/MWEdit/blob/meson/Common/Time/tasktime.cpp#L231

After doing some looking, that file may not be needed anyways so I’ve temporarily commented it out of the build script which fixed that issue as it’s no longer trying to compile it. Still working through the updates to the code. The old project file was using the C++14 standard but C++20 is much better. Also stricter, which is why there are a lot of kinks to work out.

[Spastic Hamburger]

Yep, the boar of soap was near the end. Yep, the turtle portion was fun! Duck and cover! 😀

Saw Night Tide yesterday. Wasn’t bad but it didn’t do much to actually build the conflict. It felt more like a narrative than a film

Haven’t seen No Country for Old Men but, then again, Westerns aren’t exactly my cup of tea.

[Spastic Hamburger]

Hit a bit of a snag while updating the build scripts. Now I’m getting this error in the Meson branch while the main branch builds without issue:

[1/199] "cl" "-IMWEdit.exe.p" "-I." "-I.." "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W4" "/EHsc" "/std:c++20" "/permissive-" "/O2" "/Gw" "/FdMWEdit.exe.p\Common_File_CfgFile.cpp.pdb" /FoMWEdit.exe.p/Common_File_CfgFile.cpp.obj "/c" ../Common/File/CfgFile.cpp
FAILED:  MWEdit.exe.p/Common_File_CfgFile.cpp.obj 
"cl" "-IMWEdit.exe.p" "-I." "-I.." "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W4" "/EHsc" "/std:c++20" "/permissive-" "/O2" "/Gw" "/FdMWEdit.exe.p\Common_File_CfgFile.cpp.pdb" /FoMWEdit.exe.p/Common_File_CfgFile.cpp.obj "/c" ../Common/File/CfgFile.cpp
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\ATLMFC\include\afx.h(24): fatal error C1189: #error:  Building MFC application with /MD[d] (CRT dll version) requires MFC shared dll version. Please #define _AFXDLL or do not use /MD[d]

Any ideas what that error means and how to fix it? Also, why is it complaining now but didn’t before?

You can see the changes in the PR

I’m sure I’m missing something from the Meson script but not sure what

The other warnings you’ll see in the log have been on the list for months 🙂

So it looks like it’s a setting in the project files that needs to be set in the Meson script somehow, which explains why it’s coming up now.

Not sure how to set it in Meson, though. Can’t find much about it. May take it to their GitHub page tomorrow

Another question: what triggers it? Is it something that can simply be fixed in the code or is it inherent in the MFC stuff?

[Spastic Hamburger]

Okay, I updated the Meson PR with the updates to the include paths. Should be ready for testing now if you want to give it a whirl. 🙂

[Spastic Hamburger]

Tron is great. Haven’t seen it in a while, though. Looks like the 4k version is hard to find. Supposedly, a Steelbook was released on Amazon two weeks ago but the listing says it’s unavailable and that they don’t know if it’ll be in. The regular 1080p version is easy to get, however. See something similar with a lot of Disney films. 🙁

Gaslight looks fun, will need to watch it at some point 🙂

Saw The Atomic Cafe yesterday and it both sobering and fun at the same time. Interlaced with the serious message were some very odd scenes that didn’t make much sense in the context, such as a guy in the shower randomly slipping on a bar of soap and happy music while everyone was donning hazmat suits 😛

[Spastic Hamburger]

Merged that in this morning and started on the include paths. 🙂

Ultimately, the pragmas will need investigating to see if they’re needed. Some disable warnings, which can likely be removed. It would be better to fix the issues in those cases instead of suppressing the problems

[Spastic Hamburger]

On Spastic Hamburger said

I think the heightmaps need to be processed before they can be used in the tools for the Elderscrolls but I’m not entirely sure how that works. Can try to find out, though!

Not necessarily! In theory, archive formats support sizes of several exabytes. As for downloading speed, it’d be a pain on anything but a 1 Gbps fiber connection (would only take an hour there) but a download manager would help with that. Storage would also be an issue, as well as unpacking the archive. To work with it and to process all of the files, it’d probably take at least a workstation class system running Linux to do things efficiently. A lot of it depends on how their data is laid out

Excellent! I’ve gotten pretty good at minesweeper over here. Took a while to truly get the hang of it but it’s pretty enjoyable!

Here’s another source: https://opentopography.org/

It’s not fully global, though. Some of the access requires a subscription, too.

[Spastic Hamburger]

As much as I like Redshirts, it’s probably Starter Villain. While it’s a James Bond parody on the surface, it runs much deeper than that.

It may be, too, that he’s referring to the trend in school where instructors insist that you over analyze works and everyone comes up with something totally different. He’s got some other good quotes, too!

Materials science has a come a long way in ninety years. For instance, we now have Kevlar which could help keep the balloons from ripping and is also incredibly lightweight.

We really don’t have enough books that go over futuristic anthropology. It’s such an interesting idea, too. 🙁

One of the science fiction stories I’m currently reading is actually about how extraterrestrial cuckoos play dumb to take over a space station. It’s a pretty fun read. It blends pop culture, a murder mystery, and humor altogether.

Been looking into sand batteries this morning: https://hackaday.com/2022/11/21/making-a-do-it-yourself-sand-battery/

They’re using them on a much larger scale, too. Or at least experimenting with it. In theory, they can be used to store excess capacity to generate electricity later. There would still need to be voltage regulation, though, as they work differently from traditional batteries in that they store thermal energy instead of electrical energy.

[Spastic Hamburger]

The trick is getting the opportunity to watch it 😛

Going to try and watch it today 🙂

Yep, Tubi is a weird place. It’s a gold mine if you love B-movies but quality films do sneak in from time to time. 😛

They’ve also got a decent selection of classics.

Speaking of, it’s been years since I watched the Benny Hill Show. Kind of been in the mood lately but I suspect I’d need something like BritBox. Going to need to check out the British streaming services at some point as the quality of British television is much better than our stuff, in my opinion. Too many soap operas! 😛

[Spastic Hamburger]

Okay, got the pull request up for the removal of legacy systems: https://github.com/Walrus-Tech/MWEdit/pull/34

Also took the liberty to modernize the syntax of the conditional compilation statements. I kept the checks for Windows as those will be needed for Linux support anyways and they’ll help provide a note to check those blocks (not all blocks are noted, though) to make sure they’re cross-platform compliant.

As for syntax style, I prefer #if MACRO and #ifndef MACRO over #ifdef MACRO and #if !MACRO but can certainly change #ifndef MACRO to #if !MACRO if the consensus is that it looks cleaner 🙂

Once that’s reviewed, I can merge it and get to work fixing up the include paths 🙂

[Spastic Hamburger]

I’ll be pushing up a new PR in the next day or so for removing legacy code. This will need a brief review before merge just to make sure it all looks good. 🙂

Just to note: it’ll need to be merged before additional edits can be made on account of how extensive the changes are and I don’t like dealing with merge conflicts if I can help it.

Once merged, I’ll start fixing the include paths in the headers and source files so that they’re more explicit. Once that’s done, I’ll merge it into the PR for the build script in preparation for testing that and (hopefully) removing the old VS files and adding Meson support to the CI (assuming I can figure that bit out). Once testing is done on the includes and build script, I can merge it all in to dev so that we can start making even larger changes. The build script, once working, is really going to help streamline everything 🙂

Along the way, I’m expecting some hiccups as we figure out all the correct settings since release engineering isn’t exactly my specialty. I sort of just stumble through it 😛

[Spastic Hamburger]

And updated again to fix some file names that I had mistyped. Once we get the build script tested, it’ll allow us to do more with restructuring the project 🙂

[Spastic Hamburger]

Haven’t watched The Atomic Cafe yet but I did catch Space Mutiny yesterday. It was a lot of fun! Terrible acting, high-speed bumper car chases, laser pistols that all sound different even though they’re all the same model…. 😀

Looks like I can get Creature from the Black Lagoon until the end of the month so I may need to give it another watch. It’s a classic!

[Spastic Hamburger]

I miss CLYDE! Only saw a little bit of it at the time. I wonder if there’s a CLYDE figurine somewhere…

Anyways! Depending on the design, it may be possible to run a snake through the works to clean things out. Would need to see it in person, though. From the research I did, it doesn’t appear that Florida has any yet 🙁

Yeah, Crichton’s works were much more serious than, say, John Scalzi’s works (which I highly recommend) are. He mostly keeps his cracks in his forwards but I do enjoy his books. The Andromeda Strain was a weak one but it was also one of his earliest.

I know I’ve mentioned this before but we really should bring back airships for shipping, at the bare minimum. As they’re in the sky, we can build them to immense size and then offload the goods by way of conveyors and the like. There are a lot of benefits to such a system, even if travel time is much slower than more traditional methods

[Spastic Hamburger]

Okay, build script has been updated again. I’ll keep updating it as I find things or things that come up during testing but it’s once again ready for a whirl 🙂

[Spastic Hamburger]

I’ve started making notes to the Dead Code issue regarding unused files. Feel free to add to it as you find them! Some of the latest additions do break the build script due to name clashes so I’ll get it updated soon so you may want to hold off on testing it until I report back 🙂

[Spastic Hamburger]

Not sure how mix-ins would work but it does work with your custom recipes. Mix-ins might clog things up but they don’t give any mention of that so maybe they’ll be fine? In theory, it wouldn’t be hard to make a new piece of equipment that handles general baked goods based on that design. Cakes would be harder so that they don’t get too tough during beating but muffins, certainly!

Ironically, Crichton wrote a piece detailing the opposite views towards the patent system. The full essay is behind a paywall and is also featured in a later edition of Jurassic Park (which is where I read it) but this page has more of a blurb than the NYT preview: https://greghowley.com/269

It’s a pretty interesting read if you can get the full essay.

Ah, found it! Looks like the estate uploaded it to his website profile 🙂

And the wooly mice are adorable! Saw the original article a while back 🙂

I think it’s different as Colossal is an American company as opposed to Australian. While we do have agreements, I don’t think they can go after Dodo of Australia for that reason but I’m definitely not a trademark lawyer 😛

[Author]

Posts